[Tickets #12187] ActiveSync: Fix warning on empty categories

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12187
------------------------------------------------------------------------------
  Ticket             | 12187
  Created By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | ActiveSync: Fix warning on empty categories
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2013-04-17 09:00) wrote:

Hi,

I've created an almost empty contact on a HTC Desire HD.

This results in the following PHP warning:
2013-04-17T10:21:00+02:00 WARN: HORDE [turba] PHP ERROR: implode() [<a  
href='function.implode'>function.implode</a>]: Invalid arguments  
passed [pid 2249 on line 2615 of  
"/datastore/DEVEL/horde/turba/lib/Driver.php"]

The XML data looks like this:
2013-04-17T10:27:44+02:00 DEBUG: [17529] I     <Add>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I      <ClientEntryId>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I        250
2013-04-17T10:27:44+02:00 DEBUG: [17529] I       </ClientEntryId>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I      <Data>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I       <POOMCONTACTS:FileAs>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I         Newcontact
2013-04-17T10:27:44+02:00 DEBUG: [17529] I        </POOMCONTACTS:FileAs>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I       <POOMCONTACTS:FirstName>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I         Newcontact
2013-04-17T10:27:44+02:00 DEBUG: [17529] I        </POOMCONTACTS:FirstName>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I       <AirSyncBase:Body>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I        <AirSyncBase:Type>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I          1
2013-04-17T10:27:44+02:00 DEBUG: [17529] I         </AirSyncBase:Type>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I         
<AirSyncBase:EstimatedDataSize>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I          0
2013-04-17T10:27:44+02:00 DEBUG: [17529] I          
</AirSyncBase:EstimatedDataSize>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I        <AirSyncBase:Data>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I
2013-04-17T10:27:44+02:00 DEBUG: [17529] I         </AirSyncBase:Data>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I        </AirSyncBase:Body>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I       <POOMCONTACTS:Categories />
2013-04-17T10:27:44+02:00 DEBUG: [17529] I       <POOMCONTACTS:Picture />
2013-04-17T10:27:44+02:00 DEBUG: [17529] I       </Data>
2013-04-17T10:27:44+02:00 DEBUG: [17529]  
Horde_Core_ActiveSync_Driver::changeMessage(@Contacts@,  ...)
2013-04-17T10:27:45+02:00 DEBUG: [17529]  
Horde_Core_ActiveSync_Driver::_smartStatMessage(@Contacts@,  
516e5d01-bbf0-47d3-a116-4479ac10017b)
2013-04-17T10:27:45+02:00 DEBUG: [17529] Updating state during change
2013-04-17T10:27:45+02:00 DEBUG: [17529] I      </Add>

I'll attach a fix shortly, I need to allocate the bug number first :)

Thomas