[Tickets #12188] ActiveSync: Trouble selecting the default addressbook on contact add/modify

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12188
------------------------------------------------------------------------------
  Ticket             | 12188
  Created By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | ActiveSync: Trouble selecting the default addressbook
                     | on contact add/modify
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2013-04-17 12:27) wrote:

Hi,

I've just debugged a silly problem for two hours. My account has two  
contact shares:
- "BACKUP"
- "Contacts"

I've never configured the "default_dir" or "sync_books" prefs. I've  
added a new contact via ActiveSync and by chance it ended up in the  
"Contacts" share.

Next I modified the contact on the AS device again. This modification  
never made it to the server, the ActiveSync log always complained it  
does not find the object with the given UID.

The problem boils down to this:
- turba/lib/Api.php:_getSources() as used by Api.php:replace()
   falls back to Turba::getDefaultAddressbook() in case "sync_books"  
is not set.

- Api.php:import() uses the first editable addressbook instead.


The attached patch make this more consistent by trying
the default addressbook first on import().


Similar problem: When the user configures a default addressbook that  
is not part of "sync_books", the same problem will appear again. It  
would be nice if we could output a warning if that's the case.
May be via a "warning notification"?

Thomas