[Tickets #12197] ActiveSync: Fix importing "low" importance setting on tasks

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12197
------------------------------------------------------------------------------
  Ticket             | 12197
  Created By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | ActiveSync: Fix importing "low" importance setting on
                     | tasks
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2013-04-19 12:55) wrote:

Hi,

setting a "low" importance value for a task is not properly imported  
from the PIM.
It will always turn up as "normal" importance.

The AS value for low importance is zero. The importance flag is  
queried via getImportance() which in turn uses _getAttribute(). Since  
empty() returns true for "0", we will use the default value of "normal".

Classic empty() vs. isset() problem. Attached patch fixes the issue.

Cheers,
Thomas