[Tickets #12192] Re: ActiveSync: Country field is not synced

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12192
------------------------------------------------------------------------------
  Ticket             | 12192
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | ActiveSync: Country field is not synced
  Queue              | Turba
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2013-04-19 13:30) wrote:

> As far as I understand the code, the country field wasn't mapped  
> before at all?
> So this should be no problem.

It's mapped in the Turba_Driver#[to|from]ASContact() methods along  
with the other fields that require special handling and can't just be  
copied over in a loop. It needs to be converted to/from the ISO  
country codes.

If you want the free-form country fields to be supported as an option  
(and I agree it would be a good idea), we should decide which field to  
standardize on when sending/receiving from the sync client. We  
probably need to keep the iso fields to avoid them getting corrupted  
by non-iso names form the client. Then it's just a matter of detecting  
the field in use on the Turba side, and converting it if necessary  
to/from the iso names.

> btw: You commited the patch file for this in  
> 2b9e0896111eb40b02324a827fc6177e2d6fa660
> Jan fixed this later on.

Yes, I saw that.

> You also commited the code changes accidentally together with the  
> imaddress stuff. Though I don't mind getting the code applied :o)

*sigh* These 60-70 hour weeks are killing me. I wonder what it would  
feel like if I ever coded while I was not half asleep for a change. :)

Sorry, but I'll have to revert it until it's implemented as above :)