[Tickets #12200] Re: ActiveSync: Fix broken timezone on "due by" and "delayed start" fields

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12200
------------------------------------------------------------------------------
  Ticket             | 12200
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | ActiveSync: Fix broken timezone on "due by" and
                     | "delayed start" fields
  Queue              | Nag
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2013-04-19 16:24) wrote:

>>> Please keep my "Signed-off-by:" line when applying the patch,
>>> just append yours below mine.
>>
>> Sure, not a problem, though I've been committing them as authored by
>> you, with me signing off on it. You want it authored by you and you
>> signing off on it too?
>
> Either remove the Signed-off-by stuff completely if it's unwanted by horde
> or just add yours without replacing mine :)

So, just keep doing it like I have been then.

> The linux kernel subsystem maintainers add their Signed-off-by next  
> to the original author's one, but I guess horde does not need the  
> strong "guarantees" as the kernel people do.

The patch gets applied to the tree as the person who submitted it. The  
person from Horde who commits it (and therefore approves it) is the  
one who "signed off" on it. This gives the author credit (his name is  
in the repository) and the person who approved it can be then be later  
tracked down and beaten with a wet noodle if the patch broke something  
important.