[Tickets #12248] Wrong initial sync_calendars preference

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: http://bugs.horde.org/ticket/12248
------------------------------------------------------------------------------
  Ticket           | 12248
  Erstellt Von     | lauffer at ph-freiburg.de
  Zusammenfassung  | Wrong initial sync_calendars preference
  Warteschlange    | Kronolith
  Version          | 4.0.4
  Typ              | Bug
  Status           | Unconfirmed
  Priorität        | 2. Medium
  Milestone        |
  Patch            | 1
  Zuständige       |
------------------------------------------------------------------------------


lauffer at ph-freiburg.de (2013-05-13 09:14) hat geschrieben:

Hello!

In conf/prefs.php round about line 278 we set the sync_calendars  
preference if unset/empty:

if (empty($sync)) {
   $GLOBALS['prefs']->setValue('sync_calendars',  
serialize(array(Kronolith::getDefaultCalendar())));
}

This may end in a wrong entry if the user has other calendars (f.e.  
shared ones by other users), too. In our cases our customers f.e. got  
its 1st foreign calendar synced.

This wrong entry will not be shown in the webfrontend.

We fixed the problem with just use calendars owned by this user:

$GLOBALS['prefs']->setValue('sync_calendars',  
serialize(array(Kronolith::getDefaultCalendar(Horde_Perms::EDIT,  
true))));

What do you think? Is this bugfix ok?



lauffer at ph-freiburg.de (2013-05-13 09:14) hat hochgeladen:  
kronolith-sync_calendars.patch

http://bugs.horde.org/h/services/download/?module=whups&actionID=download_file&file=kronolith-sync_calendars.patch&ticket=12248&fn=%2Fkronolith-sync_calendars.patch