[Tickets #12051] Re: Empty "Owners" "Requesters" in History summary

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12051
------------------------------------------------------------------------------
  Ticket             | 12051
  Updated By         | heinz at htl-steyr.ac.at
  Summary            | Empty "Owners" "Requesters" in History summary
  Queue              | Whups
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Jan Schneider
------------------------------------------------------------------------------


heinz at htl-steyr.ac.at (2013-06-22 13:54) wrote:

I have had the same problem.
I've traced the problem and it relays not on whups.
Problem stays in rendering email-vars.

My actual installation using Horde_Core 2.6.0
in Horde/Core/Ui/VarRenderer/Html.php, function  
_renderVarDisplay_email code looks like that:

} else {
             $addrs=  
$GLOBALS['injector']->getInstance('Horde_Mail_Rfc822')->parseAddressList($email_val,  
array(
                 'limit' => 1
             ));
             $display_email = $var->type->getProperty('strip_domain')
                 ? $addr->mailbox . ' (at) ' . str_replace('.', '  
(dot) ', $addr->host)
                 : $addr->bare_address;

             return nl2br(htmlspecialchars($display_email));
         }

$addrs is retrieved but later $addr (without the "s") is used and  
$addrs is an array ($addr should be replaced by $addrs[0])

It seems that this bug is resolved in git

commit c0850e81710d667e144415a1e09c5b7903c0279f
Author: Jan Schneider <jan at horde.org>
Date:   Fri Jun 14 17:24:40 2013 +0200

     [jan] Fix rendering of email addresses in inactive forms.

:100644 100644 bc256d4... ec2aa8e... M   
framework/Core/lib/Horde/Core/Ui/VarRenderer/Html.php

Code here looks like this:
         } else {
             $addrs =  
$GLOBALS['injector']->getInstance('Horde_Mail_Rfc822')->parseAddressList($email_val,  
array(
                 'limit' => 1
             ));

             $display = array();
             foreach ($addrs as $addr) {
                 $display_email = $var->type->getProperty('strip_domain')
                     ? $addr->mailbox . ' (at) ' . str_replace('.', '  
(dot) ', $addr->host)
                     : $addr->bare_address;
                 $display[] = htmlspecialchars($display_email);
             }

             return implode(', ', $display);
         }


Updating Horde/Core/Ui/VarRenderer/Html.php to actual git version  
fixed the problem in my case