[Tickets #12519] Re: Inconsistent use of $user & $username in passwd/lib/Driver/Ldap.php

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12519
------------------------------------------------------------------------------
  Ticket             | 12519
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | Inconsistent use of $user & $username in
                     | passwd/lib/Driver/Ldap.php
  Queue              | Passwd
  Version            | Git master
  Type               | Bug
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Slusarz <slusarz at horde.org>
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2013-08-01 12:21) wrote:

> Jan's commit  
> https://github.com/horde/horde/commit/a6cc00a83599434e441b824050248a2b7334b2cd
>
> put the variables to $username now it's back to $user?

Because #12331 was an incorrect fix.  Passwd_Driver_Ldap inherits from  
Passwd_Driver.  In Passwd_Driver, $user is used.  Using anything else  
will throw PHP strict warnings since the method signatures do not match.