[Tickets #12523] Re: AS: mix of unix timestamp and modseq breaks sync

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12523
------------------------------------------------------------------------------
  Ticket             | 12523
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | AS: mix of unix timestamp and modseq breaks sync
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2013-08-07 17:54) wrote:

> Horde_ActiveSync_Connector_Importer::importMessageDeletion() looks  
> affected, too.

It uses the same Horde_Core_ActiveSync_Driver::changeMethod call so  
this will be fixed by the same change.

> Same for ::importMessageMove() though that is unsupported by the  
> Horde_Core part for non-message items. Still it would write wrong  
> modseq value into the database before throwing the exception in  
> Horde_Core_ActiveSync_Driver::moveMessage().

I'm not sure I follow. The exception in  
Horde_Core_ActiveSync_Driver::moveMessage() will be thrown before the  
state is updated. It's called in ::importMessageMove() on line 277,  
the state is updated on line 295 - which won't be reached because the  
exception is not caught and propagates up the call stack.