[Tickets #12600] Re: Horde_History::getByModSeq() broken by design?

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12600
------------------------------------------------------------------------------
  Ticket             | 12600
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | Horde_History::getByModSeq() broken by design?
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2013-08-22 16:17) wrote:

>> Returning the most recent entry doesn't work because the query
>> doesn't specify any order, so selectAssoc() will return whatever
>> happens to be the last returned row.
>
> The function searches for unique object uids that changed during a  
> given modseq range.
> So it's not important which row it returns.
>
> If we want to return the most recent row, we could add an "ORDER BY  
> modseq DESC" statement, though it's not currently not needed. The  
> user can use the getLatestEntry($object_uid) if really needed.

That won't work, because columns in the ORDER BY clause need to be in  
the SELECT list too, in pgsql. selectAssoc() won't work with three  
columns though.

If the actual values of the array don't matter, why are they returned  
at all? If the purpose of the method is to just return object IDs, why  
doesn't it simply return object IDs?