[Tickets #12572] Re: Search from top navigation broken with git HEAD

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12572
------------------------------------------------------------------------------
  Ticket             | 12572
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | Search from top navigation broken with git HEAD
  Queue              | IMP
  Version            | Git master
  Type               | Bug
-State              | Feedback
+State              | Resolved
  Priority           | 1. Low
  Milestone          |
-Patch              | 1
+Patch              |
-Owners             |
+Owners             | Jan Schneider
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2013-08-23 11:55) wrote:

This problem was two-fold. For one we didn't generate unencoded URLs  
for URI_SEARCH and URI_THREAD.
The other problem is that we unconditionally (and incorrectly) cast  
all parameters to strings in Horde_Tree#addNodeParams(). The problem  
is that for JS tree renderers, those need to be set to raw first, if  
they are Horde_Url objects. That should happen only in the JS  
renderer. But removing the string cast from Horde_Tree is a BC break,  
so we have to deal with raw URLs even in HTML renderers. At least  
until H6.