[Tickets #12606] AS: Fix sync loop if all messages in a folder were filtered on initial sync

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12606
------------------------------------------------------------------------------
  Ticket             | 12606
  Created By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | AS: Fix sync loop if all messages in a folder were
                     | filtered on  initial sync
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2013-08-23 15:43) wrote:

 From the patch:

[PATCH] Fix sync loop if all messages in a folder were filtered on
  initial sync

We are only calling $folder->setChanges() if we found changes for a folder.
If all messages are older than our filter window, we never called  
setChanges().
Therefore the total message count was still zero.

The next time we ping() the folder, the total message count
does not match for the folder -> we have a positive "ping".
This results in a sync loop.

Since we simplified the CONDSTORE / non-CONDSTORE handling,
there is no need to store "total_messages" in a separate variable.
Just get it from the saved IMAP state which we update unconditionally.




Thomas Jarosch <thomas.jarosch at intra2net.com> (2013-08-23 15:43)  
uploaded:  
0001-Fix-sync-loop-if-all-messages-in-a-folder-were-filte.patch

http://bugs.horde.org/h/services/download/?app=whups&actionID=download_file&file=0001-Fix-sync-loop-if-all-messages-in-a-folder-were-filte.patch&ticket=12606&fn=%2F0001-Fix-sync-loop-if-all-messages-in-a-folder-were-filte.patch