[Tickets #12606] Re: AS: Fix sync loop if all messages in a folder were filtered on initial sync

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12606
------------------------------------------------------------------------------
  Ticket             | 12606
  Updated By         | Git Commit <commits at lists.horde.org>
  Summary            | AS: Fix sync loop if all messages in a folder were
                     | filtered on  initial sync
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Git Commit <commits at lists.horde.org> (2013-08-26 15:46) wrote:

Changes have been made in Git (master):

commit 6b7193aefc3295d925919b7608ff7b2f7ff8f86c
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date:   Fri Aug 23 17:33:37 2013 +0200

     Fix sync loop if all messages in a folder were filtered on initial sync

     We are only calling $folder->setChanges() if we found changes for  
a folder.
     If all messages are older than our filter window, we never called  
setChanges().
     Therefore the total message count was still zero.

     The next time we ping() the folder, the total message count
     does not match for the folder -> we have a positive "ping".
     This results in a sync loop.

     Since we simplified the CONDSTORE / non-CONDSTORE handling,
     there is no need to store "total_messages" in a separate variable.
     Just get it from the saved IMAP state which we update unconditionally.

     Bug: 12606 - Fix regression caused by addition of message count  
check in imap pinging.

     Signed-off-by: Michael J Rubinsky <mrubinsk at horde.org>

  .../lib/Horde/ActiveSync/Folder/Imap.php           |   21 ++++---------------
  .../lib/Horde/ActiveSync/Imap/Adapter.php          |    8 +++---
  2 files changed, 9 insertions(+), 20 deletions(-)

http://git.horde.org/horde-git/-/commit/6b7193aefc3295d925919b7608ff7b2f7ff8f86c