[Tickets #12605] Re: AS: Fix loss of PINGABLE flag

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12605
------------------------------------------------------------------------------
  Ticket             | 12605
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | AS: Fix loss of PINGABLE flag
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2013-08-26 20:17) wrote:

> in case of an "xxx_InvalidRequest" exception was thrown?
> Was that a copy'n'paste error or intentional?

This was intentional and is what caused the PING request to terminate.  
Since, technically, it's an invalid request we were terminating the  
PING, and telling the client to issue a full SYNC.

This has now been changed to simply ignore the invalid request and  
behave as though the "bad" collection simply wasn't included in the  
request (while keeping it marked as PINGABLE so when it *is*  
available, we will start PINGing it).