[Tickets #12636] Re: Core: Fix 'activesync_replyposition' pref readout

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12636
------------------------------------------------------------------------------
  Ticket             | 12636
  Updated By         | Git Commit <commits at lists.horde.org>
  Summary            | Core: Fix 'activesync_replyposition' pref readout
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Git Commit <commits at lists.horde.org> (2013-08-30 17:25) wrote:

Changes have been made in Git (master):

commit 3688d8c13448e002c04b80e8491cedb73366636b
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date:   Wed Aug 28 19:21:35 2013 +0200

     Fix 'activesync_replyposition' pref readout

     The moment we read out the 'activesync_replyposition'
     in the constructor was before the user is authenticated.

     Therefore the prefs backend will return the default value,
     which is 'bottom'. Setting the pref to 'top' via the UI never worked.

     Fix it by delaying the read out until the reply/forward action.
     Keep "reply_top" parameter handling as compatible as possible.

     Bug 12636

     Signed-off-by: Michael J Rubinsky <mrubinsk at horde.org>

  .../Core/lib/Horde/Core/ActiveSync/Driver.php      |   14 ++++++++------
  .../lib/Horde/Core/Factory/ActiveSyncBackend.php   |    3 +--
  2 files changed, 9 insertions(+), 8 deletions(-)

http://git.horde.org/horde-git/-/commit/3688d8c13448e002c04b80e8491cedb73366636b