[Tickets #12712] Re: H3->H5 Migration Postgres problems

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12712
------------------------------------------------------------------------------
  Ticket             | 12712
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | H3->H5 Migration Postgres problems
  Queue              | Horde Base
  Version            | 5.1.2
  Type               | Bug
-State              | Unconfirmed
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2013-10-07 17:19) wrote:

The first part is unnecessary and in incorrect hardcoding. Missing  
sequences are already catched in the migration scripts.

For the second part I'm not sure either. First of all, it should not  
contain and debug code, and the conversion should be unconditionally  
when converting to binary.
Without taking a closer look at the code, the correct fix would  
probably be to do this in the base driver and  loop all values there  
and write them back using Horde_Db_Value.