[Tickets #12930] Re: AS: Endless loop with Samsung phone

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12930
------------------------------------------------------------------------------
  Ticket             | 12930
  Updated By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | AS: Endless loop with Samsung phone
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2014-01-21 15:29) wrote:

>> Not sure about the infinite loop, but if helps you, it's dying
>> because the MAXITEMS node is not expected. You can see this in
>> Horde_ActiveSYnc_Request_Sync::  line 1142 where there is a TODO to
>> remind me to implement it when we implement the RI cache.
>
> ...and that is EXACTLY why it loops. There is no escape from the  
> while() loop in that case.

Thanks for the analysis!

May be we should add a sanity limit of 5.000+ "sync options" the next  
time an AS client sends us an unexpected tag ;) Just log it, bail out  
of the loop and continue.

The user mentioned something about a recent OTA Android update for her  
phone. I have to ask for the specific model again. May be that update  
"enabled" the RI collection.

@Arjen: I still run 2.8.5 because of QA. When I update to a new  
version, I have to test all the devices I have floating around again.  
Therefore I prefer to apply known fixes to 2.8.5 and will update every  
few months or so to the current pear version. I also update the horde  
apps and framework at the same time ;)