[Tickets #12988] Same timezone exported multiple times in iCal format/subscription

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12988
------------------------------------------------------------------------------
  Ticket             | 12988
  Created By         | sberthelot at emisfr.com
  Summary            | Same timezone exported multiple times in iCal
                     | format/subscription
  Queue              | Kronolith
  Version            | 4.1.4
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


sberthelot at emisfr.com (2014-02-21 14:19) wrote:

The VTIMEZONE block component with same TZID gets exported multiple  
times when getting a calendar using remote ICS URL and when it  
contains TZID dates.

To reproduce simply create multiple events with timezone data (same  
timezone) and use the ICS subscription URL to download the iCal file  
(via the rpc.php file). The VTIMEZONE block appears as many times as  
the number of events using a TZID.

Here is a proposed (maybe not correctly whitespace formatted) patch  
that does the same kind of comparison than the SabreDAV code path  
(Sabre/CalDAV/ICSExportPlugin.php), it simply check if there's already  
a Timezone with the same TZID and then prevents the new component to  
be added.

This fixes the problem at least for Outlook 2010 which keeps popping  
warnings about multiple defined timezones in shared calendars.

It seems rather strange to me that there are 2 ICS export paths in the  
code ; merging them somehow could avoid managing special behavior  
multiple times (like ensuring timezone is exported only once per TZID).



sberthelot at emisfr.com (2014-02-21 14:19) uploaded:  
horde-ical-uniquetimezone.diff

http://bugs.horde.org/h/services/download/?app=whups&actionID=download_file&file=horde-ical-uniquetimezone.diff&ticket=12988&fn=%2Fhorde-ical-uniquetimezone.diff