[Tickets #13110] not all motd files are shown on login page

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/13110
------------------------------------------------------------------------------
  Ticket             | 13110
  Created By         | maciej.uhlig at us.edu.pl
  Summary            | not all motd files are shown on login page
  Queue              | Horde Base
  Version            | FRAMEWORK_5_1
  Type               | Bug
  State              | Unconfirmed
  Priority           | 3. High
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


maciej.uhlig at us.edu.pl (2014-04-12 12:26) wrote:

Imagine you've prepared, besides motd.php, motd.local.php and some  
motd.d/* files. Only last of these local files is shown on login page  
due to a flaw in loadConfiguration() of Horde.php. Namely, line 357:

$output = self::endBuffer();

inside while loop overwrites $output at every iteration. So, the  
output contains last file content only.

The solution woul be to add line:

$output = '';

befole while loop (line 349) and change line 357 to:

$output = $output . self::endBuffer();

After this fix all the motd files content is shown as intended.

Of course an additional effect of this flaw is inability of using more  
than one of other configuration files, however I haven't tested it  
becaues it looks like obvious behaviour.