[Tickets #13253] Re: Bug found in Text_Diff Mapped class, incorrect call to parent constructor

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/13253
------------------------------------------------------------------------------
  Ticket             | 13253
  Updated By         | mrpaul at gmail.com <mrpaul at gmail.com>
  Summary            | Bug found in Text_Diff Mapped class, incorrect call to
                     | parent constructor
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


mrpaul at gmail.com (2014-06-08 02:56) wrote:

In the Horde\Text\Diff\Mapped.php constructor, the call to its parent  
constructor is wrong:

parent::__construct($mapped_from_lines, $mapped_to_lines);

This produces a Fatal error: Class 'Horde_Text_Diff_Engine_' not found  
since the parent constructor expects a string and an array.

The line should be changed to:

parent::__construct('auto', array($mapped_from_lines, $mapped_to_lines));

I checked the history of the file and this seems to have been a bug  
for a while.