[Tickets #13268] Re: Kolab_Storage: PHP error on modifying contact picture

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/13268
------------------------------------------------------------------------------
  Ticket             | 13268
  Updated By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | Kolab_Storage: PHP error on modifying contact picture
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2014-06-20 13:24) wrote:

> IIRC those are different data structures in different situations.  
> How did you actually trigger an error with the current code? Editing  
> a contact picture with the Horde_Form image editing buttons worked  
> without problems.

while editing works fine and there's only one attachment in the  
produced email,
it triggers the given warning for me every time on modification (using  
git "master").

The foreach() calls I provided are in the same function "store()", so  
it's the same datastructure.
To me it looks like $object[_attachments[]['id']] is used before it's  
actually built.

If you look at the code, the second iteration is filling in the 'id' field.
--------------------------------------------------------
foreach ($object['_attachments'] as $id => $attachment) {
     $attachments['id'][] = $id;
--------------------------------------------------------