[Tickets #13297] Re: Deactivating script has no effect

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: http://bugs.horde.org/ticket/13297
------------------------------------------------------------------------------
  Ticket           | 13297
  Aktualisiert Von | kd at tu-cottbus.de
  Zusammenfassung  | Deactivating script has no effect
  Warteschlange    | Ingo
  Version          | 3.2.0RC1
  Typ              | Bug
  Status           | Resolved
  Priorität        | 1. Low
  Milestone        |
  Patch            |
  Zuständige       | Michael Slusarz
------------------------------------------------------------------------------


kd at tu-cottbus.de (2014-07-01 07:59) hat geschrieben:

> Changes have been made in Git (master):
>
> commit 394efc92faa3e119918cba09d7f9d8861b0e1ef6
> Author: Michael M Slusarz <slusarz at horde.org>
> Date:   Mon Jun 30 13:55:38 2014 -0600
>
>     [mms] Fix regression in deactivating scripts (Bug #13297).
>
>  ingo/docs/CHANGES         |    6 ++++++
>  ingo/lib/Basic/Script.php |   11 ++---------
>  ingo/package.xml          |   16 +---------------
>  3 files changed, 9 insertions(+), 24 deletions(-)
>
> http://github.com/horde/horde/commit/394efc92faa3e119918cba09d7f9d8861b0e1ef6


This is not enough. The error message is gone, but the script is not  
deactivated (at least, if transport is 'timsieved'). The activate  
method in Script/Util.php does not use the $deactivate parameter,
probably something like
  if ($deactivate) { $script['script'] = ''; }
must be added.