[Tickets #12480] Re: Autocomplete includes all addresses for a user where any of them match

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: http://bugs.horde.org/ticket/12480
------------------------------------------------------------------------------
  Ticket           | 12480
  Aktualisiert Von | marth at tsvschlieben.de
  Zusammenfassung  | Autocomplete includes all addresses for a user where any
                   | of them match
  Warteschlange    | Horde Framework Packages
  Version          | Git master
  Typ              | Enhancement
  Status           | Resolved
  Priorität        | 1. Low
  Milestone        |
  Patch            |
  Zuständige       | Michael Slusarz
------------------------------------------------------------------------------


marth at tsvschlieben.de (2014-08-07 10:41) hat geschrieben:

This commit breaks the behaviour to display all contacts when  
composing an email and then click on the "To" link.

Old: You see all contacts (until you filter them with your own search rules)
New: You see no contacts (until you filter them with your own search rules)

Proposed fix (Line 1275ff)

OLD:
if ((stripos($e_val, $name) !== false) ||
  (stripos($display_name, $name) !== false)) {

NEW:
if ((strlen($name) == 0) ||
  (stripos($e_val, $name) !== false) ||
  (stripos($display_name, $name) !== false)) {

However I'm not sure if that breaks something else - it just restores  
the old (and wanted) behaviour in compose message view.


> Changes have been made in Git (FRAMEWORK_5_2):
>
> commit 854721c2298a1b4de149b0b12523119f3dec203d
> Author: Michael M Slusarz <slusarz at horde.org>
> Date:   Mon Jul 28 00:21:56 2014 -0600
>
>     [mms] Only include e-mail addresses that match the search string  
> in the return from the search() API call (Request #12480).
>
>  turba/docs/CHANGES |    2 ++
>  turba/lib/Api.php  |   26 ++++++++++++++++++--------
>  turba/package.xml  |    2 ++
>  3 files changed, 22 insertions(+), 8 deletions(-)
>
> http://github.com/horde/horde/commit/854721c2298a1b4de149b0b12523119f3dec203d