[Tickets #13584] Re: Kronolith alarms show wrong start time

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/13584
------------------------------------------------------------------------------
  Ticket             | 13584
  Updated By         | Jasper.Olbrich at students.uni-marburg.de
  Summary            | Kronolith alarms show wrong start time
  Queue              | Kronolith
  Version            | FRAMEWORK_5_2
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
+New Attachment     | alarms.patch
------------------------------------------------------------------------------


Jasper.Olbrich at students.uni-marburg.de (2014-09-22 13:23) wrote:

Please have a look at the attached patch.

There's still something wrong with "all day" events. As far as my  
testing goes, in this block

if ($this->isAllDay()) {
    if ($this->start->compareDate($end) == 0) {
        $methods['notify']['subtitle'] = sprintf(_("On %s"),  
'<strong>' . $this->start->strtime($prefs->getValue('date_format')) .  
'</strong>');

the inner if always is false, even for one day events (because they  
are stored as "from 00:00:00 on the starting day until 00:00:00 on the  
day after the event's end day").



Jasper.Olbrich at students.uni-marburg.de (2014-09-22 13:23) uploaded:  
alarms.patch

https://bugs.horde.org/h/services/download/?app=whups&actionID=download_file&file=alarms.patch&ticket=13584&fn=%2Falarms.patch