[Tickets #13730] Re: Implementation of peer verification in TLS connections

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/13730
------------------------------------------------------------------------------
  Ticket             | 13730
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | Implementation of peer verification in TLS connections
  Queue              | Horde Framework Packages
  Type               | Enhancement
  State              | New
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2014-12-20 13:26) wrote:

> I see the point that an independent library must not rely on horde's  
> configuration. However, I see no point in storing the same  
> information multiple times. As long as the Socket Client library is  
> used within horde, horde's configuration will be available.  
> Therefore this information should be used if its available.

That's fine to want to not reproduce configs, but you simply can't  
assume globals exist outside of Horde applications and Horde_Core.   
The presence of $conf is 100% reliant on Horde_Registry being both  
available and invoked.

So this is getting better, but there simply cannot be any reference to  
global variables in Socket Client code.  These dependencies must be  
injected into Socket Client solely by configuration parameters.  This  
is the whole point of Factories and dependency injection (see  
Horde_Core).  In fact, much of Horde can be seen as the configuration  
layer to our various libraries.