[Tickets #13788] Refactor away dual steam handles in Bundled implementation

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/13788
------------------------------------------------------------------------------
  Ticket             | 13788
  Created By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | Refactor away dual steam handles in Bundled
                     | implementation
  Queue              | Horde Framework Packages
  Type               | Enhancement
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2015-01-08 02:49) wrote:

Quoting Michael M Slusarz <slusarz at horde.org>:

[Hide Quoted Text]
commit 8e28721b86544127b272855dad9855bf453b51c0
Author: Michael M Slusarz <slusarz at horde.org>
Date:   Tue Jan 6 22:31:54 2015 -0700

     [mms] Horde_Image_Exif_Bundled now supports reading data from a  
PHP stream, rather than a file.

framework/Image/lib/Horde/Image/Exif/Bundled.php |   55 +++++++++++++++++----
framework/Image/package.xml                      |   12 ++--
2 files changed, 50 insertions(+), 17 deletions(-)

http://github.com/horde/horde/commit/8e28721b86544127b272855dad9855bf453b51c0
Would be really great if we could get rid of the dual handle accesses  
in here (there's no reason this can't be accomplished with a single  
stream).  I just wanted to get this to work, so we are copying the  
data stream to a separate data stream to work with the current code.

For the record: Not using the other exif drivers because this needs to  
be done in-memory.  Saving to temp file to use exif binary or base64  
encoding to a data URL in order to use PHP's built-in exif handling is  
way too expensive.