[Tickets #14019] Folder rename via activesync is broken

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14019
------------------------------------------------------------------------------
  Ticket             | 14019
  Created By         | horde at albasoft.com
  Summary            | Folder rename via activesync is broken
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


horde at albasoft.com (2015-06-19 15:39) wrote:

I get these messages when renaming or moving a folder from Outlook2013:

2015-06-10T16:42:09+02:00 WARN: HORDE PHP ERROR: unserialize() expects  
parameter 1 to be string, resource given [pid 17446 on line 185 of  
"/var/www/html/php/horde5-pear/pear/php/Horde/ActiveSync/State/Sql.php"]
2015-06-10T16:42:09+02:00 EMERG: HORDE Call to a member function  
setServerId() on a non-object [pid 17446 on line 186 of  
"/var/www/html/php/horde5-pear/pear/php/Horde/ActiveSync/State/Sql.php"]

Folder rename works, but as a new folder after a foldersync, with  
every message downloaded again.

Problem is in "updateServerIdInState" function in  
"Horde/ActiveSync/State/Sql.php" file.
Unserialize of "sync_data" can't be done with:
     $folder = unserialize($folder);
at least using PostgreSQL as I do. I've found  somewhere else this other way:
     $folder =  
unserialize($columns['sync_data']->binaryToString($result['sync_data']));

And also, "sync_key" (primary key in "horde_activesync_state" table)  
is not taken into account in this code. I think you should get every  
"sync_key" (primary key) and update its "sync_data", to avoid mixing  
"sync_data" from several sync processes.

A patch is attached to clarify.



horde at albasoft.com (2015-06-19 15:39) uploaded:  
hordewm5-activesync_RenameFolderBugUpdateState.patch

https://bugs.horde.org/h/services/download/?app=whups&actionID=download_file&file=hordewm5-activesync_RenameFolderBugUpdateState.patch&ticket=14019&fn=%2Fhordewm5-activesync_RenameFolderBugUpdateState.patch