[Tickets #14018] Re: Kronolith syncml duplicate event detection broken

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14018
------------------------------------------------------------------------------
  Ticket             | 14018
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | Kronolith syncml duplicate event detection broken
  Queue              | Synchronization
  Version            | Git master
  Type               | Bug
-State              | Resolved
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2015-06-22 13:10) wrote:

>> Also, the date object comparison is fine, as it is automagically cast
>> to string using Horde_Date::__toString().
>
> I have tested it, and it didn't work for me. I have to use  
> compareDateTime for it to work.

Please provide a test case where this does not work. I can verify the  
following tests work:

<code>
$d1 = new Horde_Date('2015-06-20');
$d2 = new Horde_Date('2015-06-20');
var_dump($d1 == $d2);
</code>

Results
bool(true)

=========

<code>
$d1 = new Horde_Date('2015-06-20');
$d2 = new Horde_Date('2014-06-20');
var_dump($d1 == $d2);
</code>

Results
bool(false)


> Sure it has to be cast to string in that comparison, when both are  
> objects and none is a string?

Yes.