[Tickets #14130] Re: monthdayyear form element not saved in DB

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: https://bugs.horde.org/ticket/14130
------------------------------------------------------------------------------
  Ticket           | 14130
  Aktualisiert Von | birnbacs at gmail.com
  Zusammenfassung  | monthdayyear form element not saved in DB
  Warteschlange    | Horde Framework Packages
  Typ              | Bug
  Status           | Feedback
  Priorität        | 1. Low
  Milestone        |
  Patch            | 1
  Zuständige       |
------------------------------------------------------------------------------


birnbacs at gmail.com (2015-10-12 05:44) hat geschrieben:

The code in question should protect itself against not meaningful or  
erroneous parameters. It seems legitimate to not accept null as a  
format string as the null format never makes sense. The sames´goes for  
formats like an empty array, 0 and false.

More errors may wait up the call stack but this also seems to be one.

> This isn't really a correct fix. Changing == checks only for  
> equivalence of value, not type. So a value of e.g., false or 0 will  
> be considered equivalent to null in this case. Probably what is  
> happening is there is some code further up the chain that is passing  
> a false-ish value to the format_in parameter instead of null.
>