[Tickets #14130] Re: monthdayyear form element not saved in DB

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: https://bugs.horde.org/ticket/14130
------------------------------------------------------------------------------
  Ticket           | 14130
  Aktualisiert Von | birnbacs at gmail.com
  Zusammenfassung  | monthdayyear form element not saved in DB
  Warteschlange    | Horde Framework Packages
  Typ              | Bug
  Status           | Feedback
  Priorität        | 1. Low
  Milestone        |
  Patch            | 1
  Zuständige       |
------------------------------------------------------------------------------


birnbacs at gmail.com (2015-10-12 11:42) hat geschrieben:

> I agree, but if you are protecting against an "empty" value, you  
> should explicitly check for this using empty(). This makes the  
> code's intent much cleaner. Setting the equality check as you did  
> can hide other issues (such as in this case where some code is  
> passing a value that is seemingly incorrect) or make them harder to  
> track down.

True.
An additional check for is_string() would probably be overkill.