[Tickets #14153] Re: Weekly invitation adds one hour to the start time

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14153
------------------------------------------------------------------------------
  Ticket             | 14153
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | Weekly invitation adds one hour to the start time
  Queue              | Horde Framework Packages
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
-Owners             |
+Owners             | Horde Developers, Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2015-11-11 21:53) wrote:

I've narrowed it down to either a broken VTimezone definition or an  
issue in the way we sort the components in  
Horde_Icalendar::_parseTZID(). There is some strange interaction going  
on  with the transition 'end' values vs the 'time' values in this zone  
when they are being sorted such that the incorrect zone is detected as  
the correct one.

If C is the current component then:

The date we are checking (D) is larger than the C's ['time'] value and  
less than (C+1)'s ['time'] value - but because of  (C+1)'s ['end']  
value, (C+2) and above's ['time] value is less than D until at some  
point we get the correct component (C+x) where the ['time'] value is  
still less than the date we are checking, but (C+x+1)'s ['time'] value  
is larger that the date we are checking - and both are still less than  
the  (C+2) ['time'] value.

tldr; the sorted components are not correctly sorted by 'time'.  It  
could very well be the timezone definition is broken, but I'm not 100%  
sure how to tell yet.