[Tickets #14199] Re: Decoding of base64 encoded Kolab (.xml) objects is broken

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14199
------------------------------------------------------------------------------
  Ticket             | 14199
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | Decoding of base64 encoded Kolab (.xml) objects is
                     | broken
  Queue              | Kolab
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky, Thomas Jarosch
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2016-01-02 19:56) wrote:


> This commit actually breaks the unit tests. Need to track this down  
> to determine if it's a broken test or broken logic before releasing.

Ugh. This is because there is no consistency in how the  
Horde_Kolab_Storage_Driver_* classes return data from the  
::getBodyPart() method. Some return it always decoded (like  
Horde_Imap_Client), some not decoded (like CClient and the mock driver  
used in the test). This is probably the reason we didn't assume 8Bit  
encoded data when setting the mime part contents. Anyway, this  
reiterates the need to drop the non-maintained drivers going forward  
and standardize on the Horde_Imap_Client driver only.