[Tickets #13886] Re: old task completion status needs migration, new entries miss data

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/13886
------------------------------------------------------------------------------
  Ticket             | 13886
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | old task completion status needs migration, new entries
                     | miss data
  Queue              | Nag
  Version            | 4.2.4
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             | Horde Developers
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2016-02-09 05:07) wrote:


> The new entry has no "completed_date" (which sounds like an error to  
> me - missing information!), but a status of "completed".

The "completed_date" field was removed in 2011 because it is not part  
of the Kolab 2.0 format. See:  
https://github.com/horde/horde/commit/109a2bd69de0f88d9008ccc3ed4d8a092cb4095f#diff-0ef97c65debfe55ccb3b62b3056c3712

> From the user interface, both events look alike, but filtering the  
> view seems to have changed to work on "status" now (which seems like  
> a proper decision, of course).

It doesn't look like we don't consider the "status" field at all in  
code, but rather look at if the Kolab "completed" field is empty  
(not-completed) or non-empty (completed). This is not correct though  
because this field should be a percentage of completion so technically  
a non-empty field could still be considered "not-complete".

So, I'm not sure why those tasks are still showing as non-completed,  
since we are only looking at the "completed" field when considering  
this and according to your data, that part at least looks correct.

It should be noted that your nag version is quite a number of bug  
fixes behind current stable code, including a number of Kolab related  
fixes. Please upgrade to the latest stable and retest.