[Tickets #14408] addReceivedHeader() interaction with SpamAssassin trustedpath

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14408
------------------------------------------------------------------------------
  Ticket             | 14408
  Created By         | admin at dei.unipd.it
  Summary            | addReceivedHeader() interaction with SpamAssassin
                     | trustedpath
  Queue              | Horde Framework Packages
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


admin at dei.unipd.it (2016-06-22 13:23) wrote:

Horde_Pear (2.9.5)
Horde/Mime/Headers/Deprecated.php
function addReceivedHeader() adds:
Received from ... by ... (Horde Framework) with HTTP; ...

if $_SERVER['HTTPS'] is "on" adds:
Received from ... by ... (Horde Framework) with HTTPS; ...

This is "correct" but Spamassassin doesnt recognize it as a  
authenticated user on trusted path
and check message against all remote IP rules.

Q&D workaround:
diff /usr/share/pear/Horde/Mime/Headers/Deprecated.php.orig  
/usr/share/pear/Horde/Mime/Headers/Deprecated.php
146c146
<             ($is_ssl ? 'S' : '') . '; ' . date('r')
---
>             ($is_ssl ? '' : '') . '; ' . date('r')

I will open a similar bug on Spamassassin:
diff  
/usr/share/perl5/vendor_perl/Mail/SpamAssassin/Message/Metadata/Received.pm*
408c408
<   if (/ by / && / with ((?:ES|L|UTF8S|UTF8L)MTPS?A|ASMTP|HTTPU?)(?:  
|;|$)/i) {
---
>   if (/ by / && / with  
> ((?:ES|L|UTF8S|UTF8L)MTPS?A|ASMTP|HTTP(S|U)?)(?: |;|$)/i) {

Regards
Valerio Pulese