[Tickets #14301] Re: CarDav Sync problem

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14301
------------------------------------------------------------------------------
  Ticket             | 14301
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | CarDav Sync problem
  Queue              | Turba
  Version            | 4.2.13
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2016-08-18 14:23) wrote:

> This is a follow-up of bug 12955 and bug 14046. _ensureEmail() exits  
> early (even after the recent logic fix), because it doesn't do it's  
> job, as soon as an email field exists. For one it doesn't check if  
> that field actually has data.

In my testing, $this->attributes[somefield] is only set if it contains  
data. The method's job was only to ensure that there was at least one  
email field populated if we have the data -  which is why it exits  
early.

> And even if it would, that won't work with editing existing contacts  
> that may already have email fields set, if they are updated with  
> email fields that have TYPE set.

I will look at this case, though this sounds messy. Especially if the  
TYPE doesn't match any of the configured email fields.