[Tickets #14521] htmlspecialchars() error in row.inc

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14521
------------------------------------------------------------------------------
  Ticket             | 14521
  Created By         | horde.wayne at ptaff.ca
  Summary            | htmlspecialchars() error in row.inc
  Queue              | Turba
  Version            | Git master
  Type               | Enhancement
  State              | New
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


horde.wayne at ptaff.ca (2016-11-24 04:19) wrote:

I get lots of these messages logged in syslog when browsing the  
addressbook on a horde-5.2.16 webmail installation (been like that on  
previous versions as well):

[turba] PHP ERROR: htmlspecialchars() expects parameter 1 to be  
string, array given [pid 831 on line 85 of  
".../turba/templates/browse/row.inc"]

Looking at the code, I can't help but notice this line appears useless  
to me as the $shown_columns[$c] value is overwritten 6 lines below;  
please have a look at  
https://github.com/horde/horde/blob/master/turba/templates/browse/row.inc#L85

I commented out the line on my local installation with no visible  
regression whatsoever.