[Tickets #14523] Invalid argument supplied for foreach() (gollem/lib/Auth.php)

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14523
------------------------------------------------------------------------------
  Ticket             | 14523
  Created By         | horde.wayne at ptaff.ca
  Summary            | Invalid argument supplied for foreach()
                     | (gollem/lib/Auth.php)
  Queue              | Gollem
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


horde.wayne at ptaff.ca (2016-11-26 19:57) wrote:

I get these once in a while in syslog, under a Horde-5.2.6 webmail  
installation.

[gollem] PHP ERROR: Invalid argument supplied for foreach() [pid 8891  
on line 338 of "?/gollem/lib/Auth.php"]

Tracing the behaviour, it appears the following code line 336:

   $passwords = $session->get('gollem', 'backends_password',  
$session::ENCRYPT);

does not always assign an array, sometimes it assigns a binary string  
(related to the json_encode() behavior described in bug #14522  
perhaps?):

I'd hence suggest, if this binary string behavior is to be expected,  
to change line 337 from:

   if ($passwords) {

to:

   if (is_array($passwords)) {

so that this syslog message is silenced.

Thanks!