[Tickets #14525] Re: Fix warnings in Google Maps API calls

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14525
------------------------------------------------------------------------------
  Ticket             | 14525
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | Fix warnings in Google Maps API calls
  Queue              | Horde Base
  Version            | 5.2.12
  Type               | Enhancement
-State              | New
+State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
-Owners             |
+Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2016-12-02 20:44) wrote:

> When using the Google Maps API, three warnings are shown in the  
> console ( NoApiKeys,  RetiredVersion and  SensorNotRequired). The  
> attached patch fixes these.

> I'm not entirely sure which version to choose to replace the retired  
> 'v=3.5', both 'v=3' and 'v=3.26' seem to work fine as of today.

According to the documentation, requesting a retired version will  
always return the current "frozen" version. So the current code  
*should* be fine. However, Google recommends for basic usage to  
request the "release" version (v3) so we will go with that.

> The first will probably prevent future warnings about retired  
> versions (as it will always select the latest released version), at  
> the risk that something might break if it is incompatible with  
> existing Horde code. The latter will prevent that, at the 'cost' of  
> quarterly (or half-yearly) updates of the version to prevent this  
> warning from popping up again.
>
> Last it also changes 'maps.google.com' to 'maps.googleapis.com' as  
> this seems to be the recommended name now.

Thanks!