[Tickets #14548] php-horde-crypto: needs updating for gpg2 cli changes

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14548
------------------------------------------------------------------------------
  Ticket             | 14548
  Created By         | nish.aravamudan at canonical.com
  Summary            | php-horde-crypto: needs updating for gpg2 cli changes
  Queue              | Horde Framework Packages
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


nish.aravamudan at canonical.com (2016-12-22 23:42) wrote:

gpg2 (now the default e.g. on Ubuntu), has a different CLI output  
format. But the Horde Crypto library relies on parsing that output for  
self-verification (and I assume, therefore, for behavior).

The changes in the attached patch include setting a GPG environment  
variable (without which you get a cryptic error message from gpg2) and  
then setting some global flags for gpg (--keyid-format short and (if  
not v1) --pinentry-mode loopback).

I also split testVerifyPassphrase into two tests. This is because gpg2  
always spawns a gpg-agent which caches passphrases. So within one gpg2  
session (which each test counts as), the first successful message  
decryption (using the correct passphrase) ends up staying cached and  
falsely passing the bad passphrase case. Alternatively, the function  
could be left as one and the order of the calls could be changed.



nish.aravamudan at canonical.com (2016-12-22 23:42) uploaded:  
update_tests_gnupg2.patch

https://bugs.horde.org/h/services/download/?app=whups&actionID=download_file&file=update_tests_gnupg2.patch&ticket=14548&fn=%2Fupdate_tests_gnupg2.patch