[Tickets #12736] Re: Automatic S/MIME encryption

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/12736
------------------------------------------------------------------------------
  Ticket             | 12736
  Updated By         | jnaegele at grierforensics.com
  Summary            | Automatic S/MIME encryption
  Queue              | IMP
  Version            | Git master
  Type               | Enhancement
  State              | Accepted
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


jnaegele at grierforensics.com (2017-02-03 20:42) wrote:

> The if-clause in line 55 of your patch doesn't make sense because it  
> can never be true, see the check in 39.
>
> This is a great start, thanks a lot! To be applied we would need at  
> least one of the two suggested solution for notifying about missing  
> encryption keys for certain recipients.

Sure, the check in line 39 ensures that encryption is *not* already  
enabled before attempting automatic encryption. Line 55 ensures that  
if S/MIME signing is enabled it remains enabled in addition to  
encryption.

I'm happy to contribute the remainder of the patch but I'm not sure  
how to best implement either option for notifying the user. I also  
posted on the dev mailing list for tips. Thanks!