[Tickets #14699] Errors with new code to handle iCal export of categories/tags

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: https://bugs.horde.org/ticket/14699
------------------------------------------------------------------------------
  Ticket           | 14699
  Erstellt Von     | wahnes at uni-koeln.de
  Zusammenfassung  | Errors with new code to handle iCal export of
                   | categories/tags
  Warteschlange    | Nag
  Version          | 4.2.17
  Typ              | Bug
  Status           | Unconfirmed
  Priorität        | 2. Medium
  Milestone        |
  Patch            |
  Zuständige       |
------------------------------------------------------------------------------


wahnes at uni-koeln.de (2017-09-26 10:24) hat geschrieben:

There are two problems introduced with version 4.2.17.

The first is very similar to bug #14698 and concerns the code change at

https://github.com/horde/horde/commit/72560bfc1e01282cec6e9c8fdbdebfbe39a5809f#diff-c0ec275af3420bccfd7fe6f8de93f277

This code has got the right parathesis at the wrong spot as well and  
uses "$this->tags[0]" which is not correct. See #14698 for more details.

The second problem is a different one but has also been introducted  
with version 4.2.17. It leads to error messages in the log file like  
this:

HORDE [nag] PHP ERROR: Undefined offset: 0 [pid 11411 on line 1245 of  
"[...]/nag/lib/Task.php"]

It seems that the "$priorityMap" might be missing an entry at index 0,  
i.e. "0 => 0,", but I'm not sure that adding a line to that effect  
around line 1239 of Task.php would be a proper fix because I don't  
understand what those magic values do.