[Tickets #14777] compatibility with php 7.2

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14777
------------------------------------------------------------------------------
  Ticket             | 14777
  Created By         | mail at webthatworks.it
  Summary            | compatibility with php 7.2
  Queue              | Horde Framework Packages
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


mail at webthatworks.it (2018-02-04 00:01) wrote:

Hi,

there are 2 minor incompatibilities with php 7.2

1)
HORDE: PHP ERROR: ini_set(): Cannot set 'user' save handler by  
ini_set() or session_module_name() [pid 2887 on line 95 of  
"/usr/share/php/Horde/SessionHandler.php"]

line 95 can simpli be deleted

2)
HORDE: PHP ERROR: count(): Parameter must be an array or an object  
that implements Countable [pid 7442 on line 371 of  
"/usr/share/php/Horde/ActiveSync/State/Sql.php"]

         if(is_array($this->_changes)) {
           $c = count($this->_changes);
         } else {
           $c = 0;
         }
$this->_logger->meta(
             sprintf('STATE: Saving state: %s',
                 serialize(array(
                     $params['sync_key'],
                     $params['sync_data'],
                     $params['sync_devid'],
                     $params['sync_mod'],
                     $params['sync_folderid'],
                     $params['sync_user'],
                     $c,
                     time()))
                 )
             );

I hope I can publish a cleaner patch here

https://github.com/Ivan-SB/Db