[Tickets #14944] Re: CardDAV: Bad comma separation for CATEGORIES property, aka tags

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/14944
------------------------------------------------------------------------------
  Ticket             | 14944
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | CardDAV: Bad comma separation for CATEGORIES property,
                     | aka tags
  Queue              | Turba
  Version            | FRAMEWORK_5_2
  Type               | Bug
-State              | Unconfirmed
+State              | Feedback
  Priority           | 2. Medium
  Milestone          |
  Patch              |
-Owners             |
+Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2019-09-28 18:58) wrote:

Yes, we store it with a comma-space separator, but only internally in  
Turba. When the Turba_Object is converted to a vCard, this property is  
split and trimmed in Turba_Tagger::split();

I'll have to trace the code after I get a Thunderbird install going to  
see where this is(not) happening.

> When syncing address book entry via CardDAV Horde is sending the  
> CATEGORIES property with wrong separation. Horde internally uses  
> categories as tags (or vice versa).
>
> RFC is postulating for CATEGORIES property value: "One or more text  
> values separated by a COMMA character"
> https://tools.ietf.org/html/rfc6350#section-6.7.1
>
> Horde separates by a comma and a space character.
>
> This misbeavior is coming from function synchronizeTags(array $tags)  
> in turba/lib/Object.php
> ...
> $this->setValue('__tags', implode(', ', $tags));
> ...
> https://github.com/horde/turba/blob/master/lib/Object.php#L313
>
> Some CardDAV clients , for example Thunderbird plugin CardBook,  
> adding the additional space char to the name of the category . As  
> CardBook is using categories for grouping cards, this leads to lots  
> of confusion.
>
> Looking forward to seeing this fixed.
>