[Tickets #14944] Re: CardDAV: Bad comma separation for CATEGORIES property, aka tags

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: https://bugs.horde.org/ticket/14944
------------------------------------------------------------------------------
  Ticket           | 14944
  Aktualisiert Von | bugs.horde.org at ulle.dyndns.org
  Zusammenfassung  | CardDAV: Bad comma separation for CATEGORIES property,
                   | aka tags
  Warteschlange    | Turba
  Version          | FRAMEWORK_5_2
  Typ              | Bug
  Status           | Feedback
  Priorität        | 1. Low
  Milestone        |
  Patch            |
  Zuständige       | Michael Rubinsky
------------------------------------------------------------------------------


bugs.horde.org at ulle.dyndns.org (2019-09-29 20:54) hat geschrieben:

Thanks for digging into this. And for pointing out where I was wrong.

The trimming for CardDAV export is done in function tovCard(...) ,  
case '__tags':
https://github.com/horde/turba/blob/master/lib/Driver.php#L1818
leading to  
https://github.com/horde/Core/blob/master/lib/Horde/Core/Tagger.php#L89

I was seeing the misbehavior with a Debian Jessie installation (which  
is oldoldstable now), where
case '__tags': is not calling Turba_Tagger::split() but doing a simple  
explode(',', $val) instead. And unfortunately I thought the error is  
caused by synchronizeTags(), which hasn't changed much since then.

So this was fixed ages ago, for Debian since Stretch/9 , as I see now.
Sorry for stealing your time, Michael.


> ...and I can't reproduce this using the 'Card Book' add on to  
> Thunderbird as described in the ticket.  My tags are being correctly  
> trimmed as they are synchronized.
>
> Please provide a step-by-step way of reproducing this.