[Tickets #15050] Re: PHP 8 breaks Horde_Imap_Client_Socket::_fetchCmd

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: https://bugs.horde.org/ticket/15050
------------------------------------------------------------------------------
  Ticket             | 15050
  Updated By         | anna.larch at gmx.net
  Summary            | PHP 8 breaks Horde_Imap_Client_Socket::_fetchCmd
  Queue              | Horde Framework Packages
  Type               | Bug
  State              | Unconfirmed
  Priority           | 3. High
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


anna.larch at gmx.net (2021-02-17 08:59) wrote:

> When using Horde_Imap_Client_Fetch_Query::headers like this:
>
>
> 		$query->headers(
> 			'references', [ 'references' ], [
> 				'cache' => true,
> 				'peek' => true,
> 			]
> 		);
>
> the string comparison in Horde_Imap_Client_Socket::_fetchCmd Line  
> 2932 doesn't work as expected any more in PHP8.
>
>
> It results in an IMAP error:
>
> C: 3 UID FETCH 904 (ENVELOPE FLAGS INTERNALDATE  
> BODY.PEEK[references.HEADER.FIELDS (REFERENCES)])
> S: 3 BAD Error in IMAP command UID FETCH: Invalid BODY[..] section  
> (0.001 + 0.000 secs).
>
> One option would be to replace the line:
>
> $cmd = ( $key == 0 )
>
> with:
>
> $cmd = ( is_string( $key ) === true && ( $key == 0 ) === false )
>

Please note this breaks IMAP for PHP 7 instead, so it's just a work  
around for the  moment.