[chora] small bug

Mathieu Arnold arn_mat@club-internet.fr
Thu, 01 Mar 2001 02:08:00 +0100



Anil Madhavapeddy wrote:
> 
> On Wed, Feb 28, 2001 at 11:58:00AM +0100, Mathieu Arnold wrote:
> >
> > what you committed was a bit wrong ;)
> > you were replacing 2 spaces by a single   which is wrong, we cannot
> > put 2   because the line could became unbreakable, which is wrong
> > too, so, just do as it's done in cvsweb.cgi, and do that :
> >
> 
> Doh, thats what I get for committing in a hurry!  I've fixed up the
> interface a bit more, so everything should (hopefully) go through
> htmlspaces() now.  Does that look ok?  I'll have a lot more time to
> look at Chora again in a few weeks, I hope! MIME handling is going to
> get sorted out next :)

it's getting better all the time :)
just one thing, say, i have 3 spaces somewhere in a line that are used
to make it render better, well, with this code, it would result in :
"   ", so, we could do a :

diff -u -r1.24 diff.php
--- diff.php    2001/02/28 21:01:59     1.24
+++ diff.php    2001/03/01 01:05:52
@@ -19,6 +19,7 @@
     $text = htmlspecialchars($text);
     $text = str_replace("\t", '        ', $text);
     $text = str_replace('  ', '  ', $text);
+    $text = str_replace('  ', '  ', $text);
     return empty($text)?' ':$text;
 }
 
-- 
Mathieu Arnold