[chora] problem when 0 is the name of a directory

Pixel Date pixeldate@hotmail.com
Wed, 07 Mar 2001 04:21:19 -0000


Sure, next time I submit a change it will be as a diff.

>From: Jon Parise <jon@csh.rit.edu>
>Reply-To: chora@lists.horde.org
>To: chora@lists.horde.org
>Subject: Re: [chora] problem when 0 is the name of a directory
>Date: Tue, 6 Mar 2001 23:08:32 -0500
>
>On Wed, Mar 07, 2001 at 04:03:33AM -0000, Pixel Date wrote:
>
> > Line 91 of chora/lib/CVSLib/Directory.php should be changed from
> >
> >         while ($name = readdir($DIR)) {
> >
> > to
> >
> >         while (($name = readdir($DIR)) != '') {
>
>I usually prefer to use empty() for cases like this, but I don't know
>which method is better (in terms of performance or readability).
>
>Thanks for all of the suggestions you've been making.  However, do you
>think you could start submitting your changes as diffs (preferably
>unified)?
>
>--
>Jon Parise (jon@csh.rit.edu)  .  Rochester Inst. of Technology
>http://www.csh.rit.edu/~jon/  :  Computer Science House Member

PixelDate.com

Get organized with the <a 
href="http://www.pixeldate.com/organizer">PixelDate.com Organizer</a>!

_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com