mishandling of ampersands in filenames

Pixel Date pixeldate@hotmail.com
Thu, 26 Apr 2001 23:31:13 -0000


Ampersands in non-directory filenames (like K&R.doc) produce the following 
error:

Warning: Undefined offset: 0 in /home/chora/horde/chora/lib/CVSLib/File.php 
on line 94

Warning: Undefined index: in /home/chora/horde/chora/lib/CVSLib/File.php on 
line 94

Fatal error: Call to a member function on a non-object in 
/home/chora/horde/chora/cvs.php on line 83

The following fixes the problem:
diff -u File-old.php File.php
--- File-old.php        Thu Apr 26 16:00:53 2001
+++ File.php    Thu Apr 26 16:01:44 2001
@@ -147,7 +147,7 @@

         /* Call the RCS rlog command to retrieve the file information */
         $flag = ($this->flags == CVSLIB_LOG_QUICK) ? ' -r ' : ' ';
-        $cmd = $this->rep->conf['paths']['rlog'] . $flag . '"' . 
escapeShellCmd($this->queryFullPath()) . '"';
+        $cmd = $this->rep->conf['paths']['rlog'] . $flag . "'" . 
$this->queryFullPath() . "'";

         /* Try and execute it, and retrieve the output into a variable */
         if (!($pstream = popen($cmd, 'r'))) {
_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com