[chora] Fwd: Re: [PHP-DEV] Chora

Cynic cynic@mail.cz
Wed, 08 Aug 2001 13:53:20 +0200


---------------------- multipart/mixed attachment
Here it is. I could not test it because I don't have gettext 
installed here (the gettext requirement sucks, IMO. it could be
optional), so someone should test it, and eventually commit it.

Index: co.php
===================================================================
RCS file: /cvs/horde/chora/co.php,v
retrieving revision 1.7
diff -u -u -r1.7 co.php
--- co.php      2001/08/03 20:42:36     1.7
+++ co.php      2001/08/08 11:41:09
@@ -22,8 +22,6 @@
     HTTP_Compress::start();
 }
 
-$r = Horde::getFormData('r', 0);
-
 /* Should we pretty-print this output or not? */
 
 $plain = Horde::getFormData('p', 0);
@@ -32,6 +30,10 @@
 
 checkError( $file = new CVSLib_File($CVS, $fullname, CVSLIB_LOG_FULL) );
 checkError( $file->getBrowseInfo() );
+
+/* Get the revision number. Default is latest revision in HEAD. */
+
+$r = Horde::getFormData('r', $file->queryRevision());
 
 /* Is this a valid revision being requested? */
 


At 20:49 8/7/2001, Chuck Hagenbuch wrote the following:
-------------------------------------------------------------- 
>Anyone up for implementing this?
>
>----- Forwarded message from "Andrew Lindeman formally andy@php.net" 
><alindeman@php.net> -----
>    Date: Tue, 7 Aug 2001 13:09:34 -0500
>    From: "Andrew Lindeman formally andy@php.net" <alindeman@php.net>
>Reply-To: alindeman@php.net
> Subject: Re: [PHP-DEV] Chora
>      To: Richard Heyes <php@heyes-computing.net>
>
>I don't know how to make it show the current
>version, but this is the format is
>
>http://cvs.php.net/co.php/php4/NEWS&r=1.726
>
>where 1.78 is the latest revision
>
>Anybody know how to get the current version?
>
>--Andy :)
>
>On Mon, 06 Aug 2001, Richard Heyes wrote:
>> Hi,
>>       The following link used to take me to the latest version of the news 
>file,
>> is there a similar option with Chora?
>> 
>> http://cvs.php.net/viewcvs.cgi/~checkout~/php4/NEWS?content-type=text/plain
>> 
>> --
>> Richard Heyes
>> "I know not with what weapons World War III will be fought, but World War IV
>> will be fought with sticks and stones." - Albert Einstein
>> 
>> 
>> -- 
>> PHP Development Mailing List <http://www.php.net/>
>> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net
>> For additional commands, e-mail: php-dev-help@lists.php.net
>> To contact the list administrators, e-mail: php-list-admin@lists.php.net
>
>-- 
>PHP Development Mailing List <http://www.php.net/>
>To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net
>For additional commands, e-mail: php-dev-help@lists.php.net
>To contact the list administrators, e-mail: php-list-admin@lists.php.net
>
>
>----- End forwarded message -----
>
>
>-chuck
>
>--
>Charles Hagenbuch, <chuck@horde.org>
>Some fallen angels have their good reasons.
>
>-- 
>Chora mailing list: http://horde.org/chora/
>Frequently Asked Questions: http://horde.org/faq/
>To unsubscribe, mail: chora-unsubscribe@lists.horde.org
------end of quote------ 
---------------------- multipart/mixed attachment
Index: co.php
===================================================================
RCS file: /cvs/horde/chora/co.php,v
retrieving revision 1.7
diff -u -u -r1.7 co.php
--- co.php	2001/08/03 20:42:36	1.7
+++ co.php	2001/08/08 11:41:09
@@ -22,8 +22,6 @@
     HTTP_Compress::start();
 }
 
-$r = Horde::getFormData('r', 0);
-
 /* Should we pretty-print this output or not? */
 
 $plain = Horde::getFormData('p', 0);
@@ -32,6 +30,10 @@
 
 checkError( $file = new CVSLib_File($CVS, $fullname, CVSLIB_LOG_FULL) );
 checkError( $file->getBrowseInfo() );
+
+/* Get the revision number. Default is latest revision in HEAD. */
+
+$r = Horde::getFormData('r', $file->queryRevision());
 
 /* Is this a valid revision being requested? */
 

---------------------- multipart/mixed attachment


cynic@mail.cz
-------------
And the eyes of them both were opened and they saw that their files
were world readable and writable, so they chmoded 600 their files.
    - Book of Installation chapt 3 sec 7 
---------------------- multipart/mixed attachment--



>From chuck@horde.org Date: Wed,  8 Aug 2001 10:04:25 -0400
Return-Path: <chuck@horde.org>
Mailing-List: contact chora-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list chora@lists.horde.org
Received: (qmail 82700 invoked from network); 8 Aug 2001 14:06:20 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.198.7)
  by horde.org with SMTP; 8 Aug 2001 14:06:20 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 1F9A739F3; Wed,  8 Aug 2001 10:04:26 -0400 (EDT)
Received: from 206.243.191.252 ( [206.243.191.252])
	as user chuck@localhost by marina.horde.org with HTTP;
	Wed,  8 Aug 2001 10:04:25 -0400
Message-ID: <997279465.3b7146e9c5cf8@marina.horde.org>
Date: Wed,  8 Aug 2001 10:04:25 -0400
From: Chuck Hagenbuch <chuck@horde.org>
To: chora@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [chora] Fwd: Re: [PHP-DEV] Chora

Quoting Cynic <cynic@mail.cz>:

> Here it is. I could not test it because I don't have gettext
> installed here (the gettext requirement sucks, IMO. it could be
> optional), so someone should test it, and eventually commit it.

I've committed the patch. Can you say _why_ you don't like the gettext
requirement?

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
Some fallen angels have their good reasons.