[commits] Horde-Hatchery branch master updated.

Michael Rubinsky mike at theupstairsroom.com
Tue Feb 17 21:20:24 UTC 2009


The branch master has been updated.
The following is a summary of the commits. Further details on each commit
can be found below.

from: 96a3c3aaaa827d0c78aa4dfc103f5a6d51fd39e2

f37daec... Make this a class constant, add some comments
c63ff20... Add ability to pass a callback function to optionally be called when needing to redirect to FB for login. This gives client code the option to handle the way in which to display the FB login page. Continue with phpdoc cleanup
10cc0fd... Fix callback name
cad06d0... phpdoc
02beb7a... I don't see where these are used, or why we would need them...
3102822... Standardize on requesting and expeecting only JSON data back from all FB api calls.

-----------------------------------------------------------------------
commit f37daec363daab4ff400ea2faacdf7980f92c7d3
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Tue Feb 17 09:41:38 2009 -0500

    Make this a class constant, add some comments

 .../lib/Horde/Service/Facebook.php                 |   23 +++++++++++++++++--
 1 files changed, 20 insertions(+), 3 deletions(-)

http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=32e194e1cb2440f45df3318dfa1b9dc6851a35b2&r2=f37daec363daab4ff400ea2faacdf7980f92c7d3

-----------------------------------------------------------------------
commit c63ff202b0aa869ec5f85534916476dacfb935c9
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Tue Feb 17 10:07:25 2009 -0500

    Add ability to pass a callback function to optionally be called
    when needing to redirect to FB for login. This gives client code the
    option to handle the way in which to display the FB login page.
    Continue with phpdoc cleanup

 .../lib/Horde/Service/Facebook.php                 |   55 +++++++++++++++----
 1 files changed, 43 insertions(+), 12 deletions(-)

http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=f37daec363daab4ff400ea2faacdf7980f92c7d3&r2=c63ff202b0aa869ec5f85534916476dacfb935c9

-----------------------------------------------------------------------
commit 10cc0fdae7bfcbc5b578ec729d4143b1e8a0d2d2
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Tue Feb 17 10:14:23 2009 -0500

    Fix callback name

 .../lib/Horde/Service/Facebook.php                 |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=c63ff202b0aa869ec5f85534916476dacfb935c9&r2=10cc0fdae7bfcbc5b578ec729d4143b1e8a0d2d2

-----------------------------------------------------------------------
commit cad06d01e4945781af648ed15c0663d405586d8f
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Tue Feb 17 11:05:30 2009 -0500

    phpdoc

 .../lib/Horde/Service/Facebook.php                 |   78 +++++++++++++++-----
 1 files changed, 58 insertions(+), 20 deletions(-)

http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=10cc0fdae7bfcbc5b578ec729d4143b1e8a0d2d2&r2=cad06d01e4945781af648ed15c0663d405586d8f

-----------------------------------------------------------------------
commit 02beb7ab76dc6e237948c77e69a0c34765d39df0
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Tue Feb 17 11:05:55 2009 -0500

    I don't see where these are used, or why we would need them...

 .../lib/Horde/Service/Facebook.php                 |   29 --------------------
 1 files changed, 0 insertions(+), 29 deletions(-)

http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=cad06d01e4945781af648ed15c0663d405586d8f&r2=02beb7ab76dc6e237948c77e69a0c34765d39df0

-----------------------------------------------------------------------
commit 3102822a901b7dd1c309e4effa9c4a61f918c3a2
Author: Michael J. Rubinsky <mrubinsk at horde.org>
Date:   Tue Feb 17 16:19:40 2009 -0500

    Standardize on requesting and expeecting only JSON data back from
    all FB api calls.
    
    Some more code clean up as I find it

 .../lib/Horde/Service/Facebook.php                 |  126 ++++++++------------
 1 files changed, 50 insertions(+), 76 deletions(-)

http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=02beb7ab76dc6e237948c77e69a0c34765d39df0&r2=3102822a901b7dd1c309e4effa9c4a61f918c3a2




More information about the commits mailing list